Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apidoc not compiling #1760

Closed
DartBot opened this issue Feb 19, 2012 · 3 comments
Closed

apidoc not compiling #1760

DartBot opened this issue Feb 19, 2012 · 3 comments
Assignees

Comments

@DartBot
Copy link

DartBot commented Feb 19, 2012

This issue was originally filed by michael.haubenwa...@gmail.com


bleeding_edge revision 4375

d2m@zaphod:~/workspace/dartlang/dev/dart/utils/apidoc$ ./apidoc
../apidoc/html_diff.dart:306:20: warning: cannot find "body" on "Statement"
      final body = stmt.body.filter((s) => !_ignorableStatement(s));
                   ^^^^^^^^^
../apidoc/html_diff.dart:308:29: warning: cannot find "body" on "Statement"
      return _getDomMembers(stmt.body[0], domTypes);
                            ^^^^^^^^^
../apidoc/html_diff.dart:310:40: warning: cannot find "value" on "Statement"
      return _domMembersFromExpression(stmt.value, domTypes);
                                       ^^^^^^^^^^
../apidoc/html_diff.dart:312:40: warning: cannot find "body" on "Statement"
      return _domMembersFromExpression(stmt.body, domTypes);
                                       ^^^^^^^^^
../apidoc/html_diff.dart:314:29: warning: cannot find "body" on "Statement"
      return _getDomMembers(stmt.body, domTypes);
                            ^^^^^^^^^
../apidoc/html_diff.dart:316:38: warning: cannot find "trueBranch" on "Statement"
      final members = _getDomMembers(stmt.trueBranch, domTypes);
                                     ^^^^^^^^^^^^^^^
../apidoc/html_diff.dart:317:37: warning: cannot find "falseBranch" on "Statement"
      members.addAll(_getDomMembers(stmt.falseBranch, domTypes));
                                    ^^^^^^^^^^^^^^^^
../apidoc/html_diff.dart:259:27: warning: cannot find "body" on "Definition"
    return _getDomMembers(htmlMember.definition.body, domTypes);
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^
../apidoc/html_diff.dart:353:37: warning: cannot find "op" on "Expression"
    if (expr is BinaryExpression && expr.op.kind == TokenKind.ASSIGN) {
                                    ^^^^^^^
../apidoc/html_diff.dart:354:40: warning: cannot find "x" on "Expression"
      return _domMembersFromExpression(expr.x, domTypes);
                                       ^^^^^^
../apidoc/html_diff.dart:356:11: warning: cannot find "target" on "Expression"
      if (expr.target is DotExpression && expr.target.self is VarExpression &&
          ^^^^^^^^^^^
../apidoc/html_diff.dart:356:43: warning: cannot find "target" on "Expression"
      if (expr.target is DotExpression && expr.target.self is VarExpression &&
                                          ^^^^^^^^^^^
../apidoc/html_diff.dart:357:11: warning: cannot find "target" on "Expression"
          expr.target.self.name.name == 'LevelDom' &&
          ^^^^^^^^^^^
../apidoc/html_diff.dart:358:12: warning: cannot find "target" on "Expression"
          (expr.target.name.name.startsWith('wrap') ||
           ^^^^^^^^^^^
../apidoc/html_diff.dart:359:12: warning: cannot find "target" on "Expression"
           expr.target.name.name == 'unwrap')) {
           ^^^^^^^^^^^
../apidoc/html_diff.dart:360:42: warning: cannot find "arguments" on "Expression"
        return _domMembersFromExpression(expr.arguments[0].value, domTypes);
                                         ^^^^^^^^^^^^^^
../apidoc/html_diff.dart:362:40: warning: cannot find "target" on "Expression"
      return _domMembersFromExpression(expr.target, domTypes);
                                       ^^^^^^^^^^^
../apidoc/html_diff.dart:364:11: warning: cannot find "self" on "Expression"
      if (expr.self is NewExpression && expr.name.name == '_wrap' &&
          ^^^^^^^^^
../apidoc/html_diff.dart:364:41: warning: cannot find "name" on "Expression"
      if (expr.self is NewExpression && expr.name.name == '_wrap' &&
                                        ^^^^^^^^^
../apidoc/html_diff.dart:365:11: warning: cannot find "self" on "Expression"
          expr.self.arguments.length == 1) {
          ^^^^^^^^^
../apidoc/html_diff.dart:366:42: warning: cannot find "self" on "Expression"
        return _domMembersFromExpression(expr.self.arguments[0].value,
                                         ^^^^^^^^^
../apidoc/html_diff.dart:368:18: warning: cannot find "self" on "Expression"
      } else if (expr.self is VarExpression && expr.self.name.name == '_ptr') {
                 ^^^^^^^^^
../apidoc/html_diff.dart:368:48: warning: cannot find "self" on "Expression"
      } else if (expr.self is VarExpression && expr.self.name.name == '_ptr') {
                                               ^^^^^^^^^
../apidoc/html_diff.dart:369:33: warning: cannot find "name" on "Expression"
        return _membersFromName(expr.name.name, domTypes);
                                ^^^^^^^^^
../apidoc/html_diff.dart:371:47: warning: cannot find "self" on "Expression"
      final bases = _domMembersFromExpression(expr.self, domTypes);
                                              ^^^^^^^^^
../apidoc/html_diff.dart:374:42: warning: cannot find "name" on "Expression"
          return base.returnType.members[expr.name.name];
                                         ^^^^^^^^^
../apidoc/html_diff.dart:376:41: warning: cannot find "arguments" on "Expression"
    } else if (expr is NewExpression && expr.arguments.length == 1) {
                                        ^^^^^^^^^^^^^^
../apidoc/html_diff.dart:377:40: warning: cannot find "arguments" on "Expression"
      return _domMembersFromExpression(expr.arguments[0].value, domTypes);
                                       ^^^^^^^^^^^^^^
../apidoc/html_diff.dart:125:45: warning: cannot find "getter" on "Member"
      if (implMember.canGet) _addMemberDiff(implMember.getter, domTypes);
                                            ^^^^^^^^^^^^^^^^^
../apidoc/html_diff.dart:126:45: warning: cannot find "setter" on "Member"
      if (implMember.canSet) _addMemberDiff(implMember.setter, domTypes);
                                            ^^^^^^^^^^^^^^^^^
../apidoc/html_diff.dart:331:32: warning: cannot find "body" on "Statement"
      return Collections.every(stmt.body, (s) => _ignorableStatement(s));
                               ^^^^^^^^^
../apidoc/html_diff.dart:333:34: warning: cannot find "body" on "Statement"
      return _ignorableStatement(stmt.body);
                                 ^^^^^^^^^
../apidoc/html_diff.dart:335:34: warning: cannot find "trueBranch" on "Statement"
      return _ignorableStatement(stmt.trueBranch) &&
                                 ^^^^^^^^^^^^^^^
../apidoc/html_diff.dart:336:29: warning: cannot find "falseBranch" on "Statement"
        _ignorableStatement(stmt.falseBranch);
                            ^^^^^^^^^^^^^^^^
../apidoc/html_diff.dart:338:14: warning: cannot find "value" on "Statement"
      return stmt.value == null || stmt.value is ThisExpression;
             ^^^^^^^^^^
../apidoc/html_diff.dart:338:36: warning: cannot find "value" on "Statement"
      return stmt.value == null || stmt.value is ThisExpression;
                                   ^^^^^^^^^^
Parsing MDN data...
Cross-referencing dart:dom and dart:html...
Warning: no dart:dom type matches dart:htmlimpl DataListElementWrappingImplementation
Warning: no dart:dom type matches dart:htmlimpl FlagsWrappingImplementation
Warning: no dart:dom type matches dart:htmlimpl MutationCallbackWrappingImplementation
Warning: no dart:dom type matches dart:htmlimpl MutationRecordWrappingImplementation
Warning: no dart:dom type matches dart:htmlimpl WebKitCSSFilterValueWrappingImplementation
Warning: no dart:dom type matches dart:htmlimpl WebKitMutationObserverWrappingImplementation
Warning: no member Window.getComputedStyle
Warning: no member Window.getComputedStyle
Warning: no member OverflowEvent.initOverflowEvent
Generating docs...
error: File not found: dart:nativewrappers
io_libs.dart:838:29: error: cannot find type NativeFieldWrapperClass1
class _EventHandler extends NativeFieldWrapperClass1 {
                            ^^^^^^^^^^^^^^^^^^^^^^^^
io_libs.dart:3754:3: warning: cannot find type ObjectArray
  ObjectArray<String> _arguments;
  ^^^^^^^^^^^
io_libs.dart:3754:3: error: Dynamic is not generic
  ObjectArray<String> _arguments;
  ^^^^^^^^^^^^^^^^^^^

@sethladd
Copy link
Contributor

Set owner to @munificent.
Added Area-UI, Triaged labels.

@munificent
Copy link
Member

The output doesn't make this at all clear, but apidoc is actually working correctly here. The first batch of warnings before "Parsing MDN data..." are type warnings. They stem from the fact that frog doesn't currently do type inference. If/when it does, those warnings will go away, which is why I haven't changed the code to explicitly avoid them.

The "Warning:" lines are coming from apidoc itself. We could get rid of them if we wanted. They're coming from Nathan's code so I'm not sure if they're useful or not.

The last batch of errors are from frog analyzing dart:io in order to generate docs for it. Even though there are warnings/errors in the code (which I haven't looked into), it doesn't prevent apidoc from successfully generating docs for dart:io.

I'm leaving this bug open because I would definitely like to clean these up, but I just wanted you to know that apidoc is successfully building docs here.

@munificent
Copy link
Member

Apidoc is warning and error-free now.


Added Fixed label.

copybara-service bot pushed a commit that referenced this issue Oct 20, 2022
bazel_worker (https://github.com/dart-lang/bazel_worker/compare/75a947f..03717ca):
  03717ca  2022-10-19  Parker Lougheed  Fix changelog mention of required SDK version (#64)

html (https://github.com/dart-lang/html/compare/0740fc7..0bf6019):
  0bf6019  2022-10-19  Devon Carew  rev the package version in preparation for publishing (#190)

markdown (https://github.com/dart-lang/markdown/compare/d72ae07..93d0eee):
  93d0eee  2022-10-14  Kevin Moore  Misc package cleanup, mostly lints (#468)
  16781b6  2022-10-14  Kevin Moore  CI: update actions, add dependabot (#469)

source_maps (https://github.com/dart-lang/source_maps/compare/c7e8963..b031e2c):
  b031e2c  2022-10-19  Devon Carew  Update README.md (#69)

webdev (https://github.com/dart-lang/webdev/compare/5343edb..a02f073):
  a02f073  2022-10-19  Daco Harkes  Support `--source` in `FrontendServerClient` (#1760)

Change-Id: I16a0c8b2d6457874e3848a58f1e4fd1650a8d894
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265002
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants