Skip to content

Commit

Permalink
[web] Skip mediadevices_test on firefox.
Browse files Browse the repository at this point in the history
This test appears to flake 88% of the time in FF. One
potential reason could be that FF requires user interaction
(similar to the notification_permissions test), however
I don't have an explanation why it doesn't consistently time-out.

One potential theory is whether this behavior is different depending on
which FF browser version is used, but I don't have the data at the
moment to confirm.

Change-Id: Ib5b2759e0d289e44ff06ab11345c597af6cab0f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332626
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
  • Loading branch information
sigmundch authored and Commit Queue committed Oct 31, 2023
1 parent 5ca9437 commit c5baec8
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions tests/lib/lib_dart2js.status
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ html/file_sample_test: Skip # FileSystem not supported on FireFox.
html/fileapi_supported_test: Skip # FileSystem not supported on FireFox.
html/fileapi_supported_throws_test: Skip # FileSystem not supported on FireFox.
html/history_test: Skip # Issue 22050
html/mediadevices_test: SkipByDesign # Not supported on FF, likely requires user-interaction that causes timeout
html/request_animation_frame_test: Skip # Async test hangs.

[ $compiler == dart2js && $runtime == safari ]
Expand Down
3 changes: 3 additions & 0 deletions tests/lib/lib_dartdevc.status
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ typed_data/typed_data_hierarchy_int64_test: SkipByDesign # ddc does not support
[ $compiler == ddc && $runtime == chrome ]
html/js_dispatch_property_test: Skip # Timeout Issue 31030

[ $compiler == ddc && $runtime == ff ]
html/mediadevices_test: SkipByDesign # Not supported on FF, likely requires user-interaction that causes timeout

[ $compiler == ddc && $system == linux ]
html/interactive_geolocation_test: Skip # Requires allowing geo location.

Expand Down
1 change: 1 addition & 0 deletions tests/lib_2/lib_2_dart2js.status
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ html/file_sample_test: Skip # FileSystem not supported on FireFox.
html/fileapi_supported_test: Skip # FileSystem not supported on FireFox.
html/fileapi_supported_throws_test: Skip # FileSystem not supported on FireFox.
html/history_test: Skip # Issue 22050
html/mediadevices_test: SkipByDesign # Not supported on FF, likely requires user-interaction that causes timeout
html/request_animation_frame_test: Skip # Async test hangs.

[ $compiler == dart2js && $runtime == safari ]
Expand Down
3 changes: 3 additions & 0 deletions tests/lib_2/lib_2_dartdevc.status
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ mirrors/*: SkipByDesign # Mirrors not supported on web in Dart 2.0.
[ $compiler == ddc && $runtime == chrome ]
html/js_dispatch_property_test: Skip # Timeout Issue 31030

[ $compiler == ddc && $runtime == ff ]
html/mediadevices_test: SkipByDesign # Not supported on FF, likely requires user-interaction that causes timeout

[ $compiler == ddc && $system == linux ]
html/interactive_geolocation_test: Skip # Requires allowing geo location.

Expand Down

0 comments on commit c5baec8

Please sign in to comment.