Skip to content

Commit

Permalink
svg: do not rename inherited ListMixin.length= parameter
Browse files Browse the repository at this point in the history
The docs are currently broken because the inherited docs contain
references to the parameter, `newLength`, but in the overridden
setters, there is no such parameter:

https://api.dart.dev/stable/3.4.4/dart-svg/NumberList/length.html

CoreLibraryReviewExempt: No-op.
Change-Id: I27388847109adeef66cdc1ef2e4faedeac5390d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372522
Commit-Queue: Sam Rawlins <srawlins@google.com>
Auto-Submit: Sam Rawlins <srawlins@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
  • Loading branch information
srawlins authored and Commit Queue committed Jun 27, 2024
1 parent 42a1d6d commit 8ed1ce9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions sdk/lib/svg/dart2js/svg_dart2js.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2065,7 +2065,7 @@ class LengthList extends JavaScriptObject
// -- start List<Length> mixins.
// Length is the element type.

set length(int value) {
set length(int newLength) {
throw new UnsupportedError("Cannot resize immutable List.");
}

Expand Down Expand Up @@ -2390,7 +2390,7 @@ class NumberList extends JavaScriptObject
// -- start List<Number> mixins.
// Number is the element type.

set length(int value) {
set length(int newLength) {
throw new UnsupportedError("Cannot resize immutable List.");
}

Expand Down Expand Up @@ -2873,7 +2873,7 @@ class StringList extends JavaScriptObject
// -- start List<String> mixins.
// String is the element type.

set length(int value) {
set length(int newLength) {
throw new UnsupportedError("Cannot resize immutable List.");
}

Expand Down Expand Up @@ -3862,7 +3862,7 @@ class TransformList extends JavaScriptObject
// -- start List<Transform> mixins.
// Transform is the element type.

set length(int value) {
set length(int newLength) {
throw new UnsupportedError("Cannot resize immutable List.");
}

Expand Down

0 comments on commit 8ed1ce9

Please sign in to comment.