remove version checking (dart-lang/linter#4419)

lib/src/analyzer.dart

@@ -17,8 +17,6 @@ import 'package:analyzer/src/lint/util.dart' as util;
 import 'package:analyzer/src/services/lint.dart' as lint_service;
 import 'package:pub_semver/pub_semver.dart';
 
-import 'version.dart';
-
 export 'package:analyzer/dart/element/type_system.dart';
 export 'package:analyzer/src/dart/ast/token.dart';
 export 'package:analyzer/src/dart/element/inheritance_manager3.dart'
@@ -94,7 +92,8 @@ class Analyzer {
 
   /// Cache linter version; used in summary signatures.
   void cacheLinterVersion() {
-    lint_service.linterVersion = version;
+    // todo(pq): remove (https://github.com/dart-lang/linter/issues/4418)
+    lint_service.linterVersion = '1.35.0';
   }
 
   /// Create a library name prefix based on [libraryPath], [projectRoot] and

test/all.dart

@@ -23,7 +23,6 @@ import 'validate_rule_description_format_test.dart'
     as validate_rule_description_format;
 import 'verify_checks_test.dart' as verify_checks;
 import 'verify_reflective_test_suites.dart' as verify_reflective_test_suites;
-import 'version_test.dart' as version_test;
 
 void main() {
   // Redirect output.
@@ -45,5 +44,4 @@ void main() {
   validate_rule_description_format.main();
   verify_checks.main();
   verify_reflective_test_suites.main();
-  version_test.main();
 }

test/rule_test.dart

@@ -12,7 +12,6 @@ import 'package:analyzer/src/analysis_options/analysis_options_provider.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/lint/io.dart';
 import 'package:analyzer/src/lint/registry.dart';
-import 'package:analyzer/src/services/lint.dart' as lint_service;
 import 'package:analyzer/src/task/options.dart';
 import 'package:analyzer/src/utilities/legacy.dart';
 import 'package:linter/src/analyzer.dart';
@@ -24,7 +23,6 @@ import 'package:linter/src/rules/package_prefixed_library_names.dart';
 import 'package:linter/src/test_utilities/annotation.dart';
 import 'package:linter/src/test_utilities/test_resource_provider.dart';
 import 'package:linter/src/utils.dart';
-import 'package:linter/src/version.dart';
 import 'package:path/path.dart' as p;
 import 'package:test/test.dart';
 
@@ -36,7 +34,6 @@ import 'util/test_utils.dart';
 void main() {
   group('rule tests', () {
     setUp(setUpSharedTestEnvironment);
-    defineSanityTests();
     defineRuleTests();
     experiment_tests.main();
     defineRuleUnitTests();
@@ -182,13 +179,6 @@ void defineRuleUnitTests() {
   });
 }
 
-/// Test framework sanity.
-void defineSanityTests() {
-  test('linter version caching', () {
-    expect(lint_service.linterVersion, version);
-  });
-}
-
 /// Handy for debugging.
 void defineSoloRuleTest(String ruleToTest) {
   for (var entry in Directory(ruleTestDataDir).listSync()) {

tool/bot.sh

@@ -7,6 +7,7 @@
 # Fast fail the script on failures.
 set -e
 
+
 if [ "$LINTER_BOT" = "benchmark" ]; then
   echo "Running the linter benchmark..."