`dart pub publish --dry-run` does not warn about unchanged description

[osaxma]

Environment

• Dart version: Dart SDK version: 2.17.6 (stable) (Tue Jul 12 12:54:37 2022 +0200) on "macos_x64

Problem

I've created a package using dart create -t package and I forgot to change the description. When I ran dart pub publish --dry-run , I got Package has 0 warnings.

Though when I tried to publish, I got the following error:

`description` contains a generic text fragment coming from package templates (`A starting point for Dart libraries or applications`).
Please follow the guides to describe your package:
https://dart.dev/tools/pub/pubspec#description

The description that caused the error in publishing:

description: A starting point for Dart libraries or applications.

Expected Behavior:

I expected to get a warning during the dry run.

[sigurdm]

Yeah --dry-run only does a subset of all checks.

This is in spirit a duplicate of #2996

For this specific check we could perhaps improve the user-experience by having the template text include a TODO, and have a lint in the analyzer to not include any TODO's in your description. (requires also: #3391)

We do not want to implement such specific warnings in the client (what if the template changes, then the client is outdated).

We might want to look into all the server-side checks again and see which of them could be reasonably duplicated either by the analyzer or the pub client.

Currently this is not a high priority as the harm from a failed publication attempt is very small even though annoying.

[osaxma]

Thanks @sigurdm for your time.

And, Yeah I agree it's not a big deal or high priority. This would only occur in the first time the package is published and only if the description was not updated. I just thought it was worth reporting.