-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pub run
should not emit any output not from the executable
#2545
Comments
This is also breaking our ability to use the protobuf compiler; see https://travis-ci.com/github/sass/dart-sass-embedded/jobs/363118689. In general, I would expect an executable runner to never add its own output to stdout (or stderr), since those streams may be used by the underlying executable to communicate along a particular protocol. |
Even with "only print if there is a console attached" scenario, if any callers relies on stdout it will break. In travis for example, My all dart setup (that dart file was writing a .rc file and printing the tmp filename to source) was: before_script:
- source $(dart pub run xxxx) I had to add a warmup calls just to workaround this issue before_script:
# Dummy initial call
- dart pub run xxxx --help
- source $(dart pub run xxxx) As I change sdk often, just calling
and sometimes
Why not printing to stderr instead? |
Environment
pub version
orflutter pub version
: Pub 2.9.0-19.0-devProblem
Our tests are failing when run against the current dev version of the Dart SDK because
pub run
has started emitting output related to precompilation and we're expecting only output from the executable we're trying to run.This issue is not present in the current stable SDK.
Expected behavior
pub run <executable>
should only emit output from the executable itself.Actual behavior
pub run <executable>
first emitsPrecompiling executable...
and other related lines.The text was updated successfully, but these errors were encountered: