Adjust search client retry attempts #3426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isoos
changed the title
jonasfj
approved these changes
Mar 14, 2020
jonasfj
reviewed
Mar 14, 2020
| serviceUrl, | ||
| timeout: Duration(seconds: 5), | ||
| // limit to a single attempt, no need to retry after timeout | ||
| retryCount: 0, |
There was a problem hiding this comment.
We're reusing the _httpClient, so if there are connections in pool, where the remote side has closed down, we get a quick disconnect and we don't retry..
Is that wise?
Another strategy is to retry if the request didn't take 3s. It's quite common for idle TCP connections to have the remote side shutdown, without anyone noticing locally.
There was a problem hiding this comment.
But then we should also discard the _httpClient instance when this happens, as other connections could be stale too. I've filed #3431 to track it.
Currently we can filter for |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3363. The prior PR added the 5-second timeout, but the default retry on the method tried it a second time, making the original request serving to 10+ seconds. In one case this caused the user to reload the same search query several more times.