Explicit injection of Storage into ApiExporter. (#8275)

dart-lang · Nov 14, 2024 · 32fc41d · 32fc41d
1 parent 8b9b9ec
commit 32fc41d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/app/lib/package/api_export/api_exporter.dart b/app/lib/package/api_export/api_exporter.dart
@@ -50,6 +50,7 @@ final class ApiExporter {
 
   ApiExporter(
     this._db, {
+    required Storage storageService,
     required Bucket bucket,
   }) : _api = ExportedApi(storageService, bucket);
 

diff --git a/app/lib/service/services.dart b/app/lib/service/services.dart
@@ -246,6 +246,7 @@ Future<R> _withPubServices<R>(FutureOr<R> Function() fn) async {
     if (activeConfiguration.exportedApiBucketName != null) {
       registerApiExporter(ApiExporter(
         dbService,
+        storageService: storageService,
         bucket:
             storageService.bucket(activeConfiguration.exportedApiBucketName!),
       ));

diff --git a/app/test/package/api_export/api_exporter_test.dart b/app/test/package/api_export/api_exporter_test.dart
@@ -47,7 +47,8 @@ void main() {
       (fakeTime) async {
     await storageService.createBucket('bucket');
     final bucket = storageService.bucket('bucket');
-    final apiExporter = ApiExporter(dbService, bucket: bucket);
+    final apiExporter =
+        ApiExporter(dbService, storageService: storageService, bucket: bucket);
 
     await _testExportedApiSynchronization(
       fakeTime,
@@ -62,7 +63,8 @@ void main() {
     (fakeTime) async {
       await storageService.createBucket('bucket');
       final bucket = storageService.bucket('bucket');
-      final apiExporter = ApiExporter(dbService, bucket: bucket);
+      final apiExporter = ApiExporter(dbService,
+          storageService: storageService, bucket: bucket);
 
       await apiExporter.synchronizeExportedApi();