License test updates + exposing the matched position #1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Aug 5, 2025
sigurdm
reviewed
Aug 5, 2025
| /// | ||
| /// WARNING: this class is experimental, do not rely on it. | ||
| @JsonSerializable() | ||
| class Position { |
There was a problem hiding this comment.
Not sure, but would it make sense to make the class represent a range instead?
There was a problem hiding this comment.
Would that require: startOffset, endOffset, startLine, endLine, startColumn, endColumn?
Maybe we could have a Range class with Position start and Position end, both required?
There was a problem hiding this comment.
Updated the code with Range (with start and stop). PTAL.
Note: maybe this is an overkill here, but we could also emit a diff format: while marking the recognized range, we could highlight added words and also identify removed words too. Just in case the license was modified in a non-trivial way.
sigurdm
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation to update/improve the license-detection, and to eventually expose the detected license parts on the UI.
Part of #1015 and dart-lang/pub-dev#5359
I am not sure yet if this positioning is enough for the UI, e.g. we could have multiple coverage segments that would show which words were matched in the license text, and which may have been added to it, let's discuss that later (added a warning note of the fields and the class being experimental).