Skip to content

Fix golden files caused by new dartdoc update. #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/goldens/end2end/async-2.11.0.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"grantedPoints": 10,
"maxPoints": 20,
"status": "failed",
"summary": "### [*] 10/10 points: 20% or more of the public API has dartdoc comments\n\n246 out of 246 API elements (100.0 %) have documentation comments.\n\n### [x] 0/10 points: Package has an example\n\n<details>\n<summary>\nNo example found.\n</summary>\n\nSee [package layout](https://dart.dev/tools/pub/package-layout#examples) guidelines on how to add an example.\n</details>\n"
"summary": "### [*] 10/10 points: 20% or more of the public API has dartdoc comments\n\n246 out of 263 API elements (93.5 %) have documentation comments.\n\nSome symbols that are missing documentation: `async.AsyncMemoizer.AsyncMemoizer.new`, `async.ChunkedStreamReader.ChunkedStreamReader.new`, `async.DelegatingFuture.DelegatingFuture.new`, `async.DelegatingStream.DelegatingStream.new`, `async.ErrorResult.ErrorResult.new`.\n\n### [x] 0/10 points: Package has an example\n\n<details>\n<summary>\nNo example found.\n</summary>\n\nSee [package layout](https://dart.dev/tools/pub/package-layout#examples) guidelines on how to add an example.\n</details>\n"
},
{
"id": "platform",
Expand Down
4 changes: 3 additions & 1 deletion test/goldens/end2end/async-2.11.0.json_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ Detected license: `BSD-3-Clause`.

### [*] 10/10 points: 20% or more of the public API has dartdoc comments

246 out of 246 API elements (100.0 %) have documentation comments.
246 out of 263 API elements (93.5 %) have documentation comments.

Some symbols that are missing documentation: `async.AsyncMemoizer.AsyncMemoizer.new`, `async.ChunkedStreamReader.ChunkedStreamReader.new`, `async.DelegatingFuture.DelegatingFuture.new`, `async.DelegatingStream.DelegatingStream.new`, `async.ErrorResult.ErrorResult.new`.

### [x] 0/10 points: Package has an example

Expand Down
2 changes: 1 addition & 1 deletion test/goldens/end2end/dnd-2.0.1.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"grantedPoints": 20,
"maxPoints": 20,
"status": "passed",
"summary": "### [*] 10/10 points: 20% or more of the public API has dartdoc comments\n\n70 out of 72 API elements (97.2 %) have documentation comments.\n\nSome symbols that are missing documentation: `dnd`, `dnd.DraggablesAcceptor.draggableIds`.\n\n### [*] 10/10 points: Package has an example\n"
"summary": "### [*] 10/10 points: 20% or more of the public API has dartdoc comments\n\n70 out of 77 API elements (90.9 %) have documentation comments.\n\nSome symbols that are missing documentation: `dnd`, `dnd.Acceptor.Acceptor.new`, `dnd.AnimationHelper.AnimationHelper.new`, `dnd.CloneAvatarHandler.CloneAvatarHandler.new`, `dnd.DraggablesAcceptor.DraggablesAcceptor.new`.\n\n### [*] 10/10 points: Package has an example\n"
},
{
"id": "platform",
Expand Down
4 changes: 2 additions & 2 deletions test/goldens/end2end/dnd-2.0.1.json_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ Detected license: `MIT`.

### [*] 10/10 points: 20% or more of the public API has dartdoc comments

70 out of 72 API elements (97.2 %) have documentation comments.
70 out of 77 API elements (90.9 %) have documentation comments.

Some symbols that are missing documentation: `dnd`, `dnd.DraggablesAcceptor.draggableIds`.
Some symbols that are missing documentation: `dnd`, `dnd.Acceptor.Acceptor.new`, `dnd.AnimationHelper.AnimationHelper.new`, `dnd.CloneAvatarHandler.CloneAvatarHandler.new`, `dnd.DraggablesAcceptor.DraggablesAcceptor.new`.

### [*] 10/10 points: Package has an example

Expand Down
Loading