Skip to content

[native_assets_builder] Move test/data/ to test_data/ #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/native.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,22 +70,22 @@ jobs:

- run: dart pub get

- run: dart pub get -C test/data/dart_app/
- run: dart pub get -C test_data/dart_app/
if: ${{ matrix.package == 'native_assets_builder' }}

- run: dart pub get -C test/data/native_add/
- run: dart pub get -C test_data/native_add/
if: ${{ matrix.package == 'native_assets_builder' }}

- run: dart pub get -C test/data/native_add_add_source/
- run: dart pub get -C test_data/native_add_add_source/
if: ${{ matrix.package == 'native_assets_builder' }}

- run: dart pub get -C test/data/native_subtract/
- run: dart pub get -C test_data/native_subtract/
if: ${{ matrix.package == 'native_assets_builder' }}

- run: dart pub get -C test/data/package_reading_metadata/
- run: dart pub get -C test_data/package_reading_metadata/
if: ${{ matrix.package == 'native_assets_builder' }}

- run: dart pub get -C test/data/package_with_metadata/
- run: dart pub get -C test_data/package_with_metadata/
if: ${{ matrix.package == 'native_assets_builder' }}

- run: dart pub get -C example/native_add_app/
Expand Down
1 change: 1 addition & 0 deletions pkgs/native_assets_builder/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Add support for `runPackageName` to avoid native assets for packages that
the root package depends on but the package being run doesn't.
- Bump `package:native_assets_cli` to 0.4.1.
- Moved test projects from `test/data/` to `test_data/`.

## 0.3.0

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

4 changes: 2 additions & 2 deletions pkgs/native_assets_builder/test/helpers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Uri findPackageRoot(String packageName) {

final pkgNativeAssetsBuilderUri = findPackageRoot('native_assets_builder');

final testDataUri = pkgNativeAssetsBuilderUri.resolve('test/data/');
final testDataUri = pkgNativeAssetsBuilderUri.resolve('test_data/');

extension on Uri {
String get name => pathSegments.where((e) => e != '').last;
Expand Down Expand Up @@ -153,7 +153,7 @@ Future<void> copyTestProjects({
final targetFileUri = targetUri.resolveUri(pathToModify);
final sourceString = await sourceFile.readAsString();
final modifiedString = sourceString.replaceAll(
'path: ../../../',
'path: ../../',
'path: ${pkgNativeAssetsBuilderUri.toFilePath().replaceAll('\\', '/')}',
);
await File.fromUri(targetFileUri)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
native_assets_cli:
path: ../../../../native_assets_cli/
path: ../../../native_assets_cli/
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
native_assets_cli:
path: ../../../../native_assets_cli/
path: ../../../native_assets_cli/
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
dependency_overrides:
native_assets_cli:
path: ../../../native_assets_cli/
native_toolchain_c:
path: ../../../native_toolchain_c/
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
dependency_overrides:
native_assets_cli:
path: ../../../native_assets_cli/
native_toolchain_c:
path: ../../../native_toolchain_c/
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
dependency_overrides:
native_assets_cli:
path: ../../../native_assets_cli/
native_toolchain_c:
path: ../../../native_toolchain_c/
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
dependency_overrides:
native_assets_cli:
path: ../../../native_assets_cli/
native_toolchain_c:
path: ../../../native_toolchain_c/
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
native_assets_cli:
path: ../../../../native_assets_cli/
path: ../../../native_assets_cli/
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
dependency_overrides:
native_assets_cli:
path: ../../../../native_assets_cli/
path: ../../../native_assets_cli/
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
dependency_overrides:
native_assets_cli:
path: ../../../native_assets_cli/
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
dependency_overrides:
native_assets_cli:
path: ../../../native_assets_cli/
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
dependency_overrides:
native_assets_cli:
path: ../../../native_assets_cli/
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
dependency_overrides:
native_assets_cli:
path: ../../../native_assets_cli/
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
dependency_overrides:
native_assets_cli:
path: ../../../native_assets_cli/