Repository navigation
[native_toolchain_c] Track header files as build dependencies - #3728
Open
Yusufihsangorgel wants to merge 2 commits into
Open
Yusufihsangorgel wants to merge 2 commits into
Yusufihsangorgel wants to merge 2 commits into
Conversation
dcharkes
approved these changes
Oct 6, 2026
| testPackageUri.resolve('src/debug.h'), | ||
| testPackageUri.resolve('src/add.c'), | ||
| testPackageUri.resolve('src/add.h'), | ||
| testPackageUri.resolve('src/math.h'), |
Contributor
Author
There was a problem hiding this comment.
math.c and add.c both include it, and the dependencies builder doesn't dedupe.
| testPackageUri.resolve('src/debug.h'), | ||
| testPackageUri.resolve('src/add.c'), | ||
| testPackageUri.resolve('src/add.h'), | ||
| testPackageUri.resolve('src/math.h'), |
Contributor
Author
There was a problem hiding this comment.
Same cause.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3728 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 310 310
Lines 19799 19800 +1
=======================================
+ Hits 17411 17412 +1
Misses 2388 2388
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Header files can now be listed in the
sourcesof aCBuilder. They are reported as hook dependencies, and editing one reruns the build. Files ending in.hare dropped before any compiler-specific code runs. Thesourcesdoc asks users to list their headers.Following #1332 and the review of #2098, the examples and test projects list their headers in
sources. The CBuilder tests check that headers are not passed to the compiler and show up as dependencies. Inbuild_runner_caching_test.dart, editing a header reruns the build.The
nativeworkflow passed in my fork on Linux, macOS and Windows: https://github.com/Yusufihsangorgel/native/actions/runs/37115593562. On Windows the CBuilder tests ran with MSVC, including both tests changed here.The Health changelog check flags
code_assets. Its changes, like those inffigen, are limited to the README, library docs, examples and (forffigen) the hook that builds its test helpers. Neither package gets a changelog entry.Related Issues
Fixes #1332
PR Checklist
dart tool/ci.dart --alllocally and resolved all issues identified. This ensures the PR is formatted, has no lint errors, and ran all code generators. This applies to the packages part of the toplevelpubspec.yamlworkspace.CHANGELOG.mdfor the relevant packages. (Not needed for small changes such as doc typos).