Repository navigation
fix: struct member renamed due to top-level function collision (#2850) - #3725
Open
vikramsingh920 wants to merge 6 commits into
Open
vikramsingh920 wants to merge 6 commits into
vikramsingh920 wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in
ffigenwhere struct members were unnecessarily renamed with a$1suffix when a top-level function or global variable shared the same identifier.Why:
In Dart, struct field/member identifiers live inside the struct's own class scope and do not collide with top-level functions or variables. Previously,
Scope._fillNames()passed all root symbols (namer._used) down to child scopes. As a result, if a top-level C function likeFindClassexisted, any struct member namedFindClasswas mistakenly treated as a collision and renamed toFindClass$1.What changed:
pkgs/ffigen/lib/src/code_generator/scope.dart, child scopes inheriting from root now only receive type-level symbols (classLevelUsed) instead of all root symbols (_used).struct_member_toplevel_func_collision_test.dartand its expected golden bindings file.pkgs/ffigen/CHANGELOG.md.Related Issues
Fixes #2850
PR Checklist
dart tool/ci.dart --alllocally and resolved all issues identified. This ensures the PR is formatted, has no lint errors, and ran all code generators. This applies to the packages part of the toplevelpubspec.yamlworkspace.CHANGELOG.mdfor the relevant packages. (Not needed for small changes such as doc typos).