[hooks_runner] Add Rustup and Cargo environment variables to allowlist - #3545
Merged
Conversation
dcharkes
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rustup is Rust's official toolchain manager. Cargo is the Rust package manager.
Rustup and cargo use environment variables for a few things:
In particular, my builds are failing since
CARGO_HOMEis not in the allowlist.Flatpak builds are done offline, so not being able to access the existing package cache results in a build failure.
This PR adds those environment variables into the whitelist.
Related Issues
TheAppgineer/flatpak-flutter#125
PR Checklist
I’ve reviewed the contributor guide and applied the relevant portions to this PR.
I've run
dart tool/ci.dart --alllocally and resolved all issues identified. This ensures the PR is formatted, has no lint errors, and ran all code generators. This applies to the packages part of the toplevelpubspec.yamlworkspace.It threw an error for me but it seems unrelated.
'stddef.h' file not found [Lexical or Preprocessor Issue]
Ignoring that, I've separately made sure that
dart format/dart analyzedon't show anything.dart testfails several tests on my system with this error:/usr/bin/ccache: invalid option -- 'f'. Regardless, the test I added here passes.All existing and new tests are passing. I added new tests to check the change I am making.
The PR is actually solving the issue. PRs that don't solve the issue will be closed. Please be respectful of the maintainers' time. If it's not clear what the issue is, feel free to ask questions on the GitHub issue before submitting a PR.
I have updated
CHANGELOG.mdfor the relevant packages. (Not needed for small changes such as doc typos).I have updated the pubspec package version if necessary.