[native_doc_dartifier] Extract Public API Signatures for LLM Context #2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ? (node.parent as ClassDeclaration).name.lexeme | ||
| : ''; | ||
|
|
||
| if (className.isEmpty || !_isPublic(className)) return; |
There was a problem hiding this comment.
Skipped the "fields" that are outside classes, is that true, or JNIgen may generate ones that are outside classes?
Same with "methods"
| return; | ||
| } | ||
|
|
||
| final returnType = node.returnType?.toSource() ?? 'dynamic'; |
There was a problem hiding this comment.
Is the default value for the returnType, if not explicit, should be "dynamic", or "void"?
| expect(withParamsConstructor.className, 'Bar'); | ||
| expect(withParamsConstructor.name, 'withParams'); | ||
| expect(withParamsConstructor.factoryKeyword, isNull); | ||
| expect(withParamsConstructor.parameters, '(this.a, this.b, {int? k})'); |
There was a problem hiding this comment.
for (this.a, this.b) should I get the type of them to be (int? a, int? b)
| const code = ''' | ||
| class Bar { | ||
| int _privateField; | ||
| int publicField = 10; |
There was a problem hiding this comment.
Also here ... in case of final publicField = 10, the return type will be dynamic ... should I use Dart analyzer to infer its type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2309
This PR statically extracts public API signatures from Dart source code. The extracted information includes: