Skip to content

[hooks] [hooks_runner] Use any deps in example and test_data #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Jun 12, 2025

Those packages are not published, so they are only available in the git checkout. In the git checkout, they will always have the same version as the code in the workspace.

This will reduce the diff on PRs which change the version number of package:hooks etc.

Copy link

github-actions bot commented Jun 12, 2025

PR Health

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
hooks MetadataAsset
AssetSyntax
JsonObjectSyntax

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_doc_dartifier/example/native_doc_dartifier_example.dart
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

Copy link

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
hooks Breaking 0.19.3 0.19.3 0.20.0
Got "0.19.3" expected >= "0.20.0" (breaking changes)
⚠️
hooks_runner Breaking 0.21.0 0.21.0 0.22.0
Got "0.21.0" expected >= "0.22.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
hooks MetadataAsset
AssetSyntax
JsonObjectSyntax

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_doc_dartifier/example/native_doc_dartifier_example.dart
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes
Copy link
Collaborator Author

Tracking leaked API symbols in #2355

@dcharkes dcharkes requested review from HosseinYousefi and removed request for mosuem June 12, 2025 09:10
@dcharkes dcharkes merged commit 289967a into main Jun 12, 2025
27 checks passed
@dcharkes dcharkes deleted the example-deps branch June 12, 2025 10:55
@coveralls
Copy link

Coverage Status

coverage: 87.881% (-3.6%) from 91.485%
when pulling e8f1fa7 on example-deps
into e69b7c3 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants