Skip to content

[jnigen] Fix generic subinterfaces not specifying full type params #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

HosseinYousefi
Copy link
Member

Closes #2250. Classes that inherited a generic without specifying all type parameters were not generated. Filling the ones not specified with JObject?.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

Coverage Status

coverage: 78.958% (+1.2%) from 77.787%
when pulling 3d75bd2 on fix-method-move
into 6e675b3 on main.

@HosseinYousefi HosseinYousefi merged commit 8aa3f53 into main May 5, 2025
27 of 28 checks passed
@HosseinYousefi HosseinYousefi deleted the fix-method-move branch May 5, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jnigen] Classes that inherit a generic without specifying all type params are not generated
3 participants