Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a rareish bug where a specific interface type can be codegenned as a generic
ObjCObjectBase
. It can happen in methods or properties, in arguments or returns.I'm not 100% sure what causes it, but it seems to happen when the interface has type params, and is forward declared. Eg, I was able to repro it in the test by writing a method that returns an
NSArray<NSString*>*
, and forward declaringNSArray
andNSString
instead of#import
ing their headers.The bug is that in the AST these types show up as a
CXType_ObjCObject
instead of aCXType_ObjCInterface
. Their structure is exactly the same as any other interface, but the different kind enum value means that they fall through our parsing switch and default to the generic object type. So the fix is just to add this enum value to the switch.Fixes #1268