Skip to content

[native_assets_cli] Fix snake casing in JSON #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Mar 24, 2025

Closes: #2037
Closes: #2038

Fixes spelling in the JSON format:

  • prefer-dynamic -> prefer_dynamic
  • prefer-static -> prefer_static
  • assetsForLinking -> assets_for_linking

PR changes

  • pkgs/hook, pkgs/code_assets, and pkgs/data_assets

    • Introduces new schemas in the non-generated .schema.json files
    • Updates the generated schemas to pick up on the new spelling for assets_for_linking.
    • Adds test data for the new spelling.
    • Added JSON schema tests for the new spelling.
  • package:native_assets_cli

    • Generated the syntax classes
    • Deal with version skew in the mapping between syntax classes and semantic API

Version skew between hooks and SDKs

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes force-pushed the link-mode-preference-json branch 2 times, most recently from 36ceb7b to d44e0c3 Compare March 24, 2025 16:55
@dcharkes dcharkes marked this pull request as ready for review March 24, 2025 17:32
Copy link
Member

@mosuem mosuem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I think backwards compatibility makes the code less readable and is not needed on experimental features, but I know you disagree ;) )

Base automatically changed from syntax-required-conditionally to main March 26, 2025 06:46
@dcharkes dcharkes force-pushed the link-mode-preference-json branch from d44e0c3 to eb0b868 Compare March 26, 2025 06:47
@auto-submit auto-submit bot merged commit 0eeaa2d into main Mar 26, 2025
46 checks passed
@auto-submit auto-submit bot deleted the link-mode-preference-json branch March 26, 2025 06:58
@coveralls
Copy link

Coverage Status

coverage: 86.019% (+0.003%) from 86.016%
when pulling eb0b868 on link-mode-preference-json
into 4073532 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[native_assets_cli] Rename prefer-static to prefer_static in JSON [native_assets_cli] Rename assetsForLinking to assets_for_linking in JSON
3 participants