Skip to content

[jnigen] Do not fail when synthetic parameters don't have names #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[jnigen] Do not fail when synthetic parameters don't have names #1553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/jnigen/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Fixed an issue where inheriting a generic class could generate incorrect code.
- No longer generating constructors for abstract classes.
- No longer generating `protected` elements.
- Fixed an issue where synthetic methods caused code generation to fail.

## 0.11.0

Expand Down
4 changes: 4 additions & 0 deletions pkgs/jnigen/lib/src/elements/elements.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,11 @@ class Param implements Element<Param> {

final List<Annotation> annotations;
final JavaDocComment? javadoc;

// Synthetic methods might not have parameter names.
@JsonKey(defaultValue: 'synthetic')
final String name;

final TypeUsage type;

/// Populated by [Renamer].
Expand Down
2 changes: 1 addition & 1 deletion pkgs/jnigen/lib/src/elements/elements.g.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading