[native_toolchain_c] Explicitly tell linker to create position dependent or position independent executable #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… independent executable
blaugold
changed the title
blaugold
changed the title
dcharkes
approved these changes
Sep 16, 2023
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
…ent or position independent executable (#139)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assumed that
-fPIEalso affect the linking stage. This is not the case. It only affects code generation. Whether a position dependent or independent executable is generated depends on the-pieand-no-pieoptions. Compilers and compiler versions can have different defaults for creating position dependent or independent executables (apparently clang changed its default somewhere between 16 and 18). With this PR, we now pass-pieand-no-piein addition to-fPIE/-fno-PIE, when compiling an executable.