[native_assets_builder] Automatically track all Dart sources as dependencies #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthBreaking changes ✔️Details
Changelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. License Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
github-actions
bot
added
the
type-infra
I don't see any breaking changes here. |
dcharkes
requested review from
mosuem and
HosseinYousefi
and removed request for
mosuem
The log says: Breaking change report:
{
"breakingChanges": {
"label": "BREAKING CHANGES",
"children": [
{
"label": "Class HookConfigImpl",
"children": [
{
"changeDescription": "Method \"checksumDryRun\" added (required)",
"changeCode": "CE11",
"isBreaking": true,
"type": "minor"
}
]
}
]
},
"nonBreakingChanges": {
"label": "Non-Breaking changes",
"children": [
{
"label": "Class BuildConfigImpl",
"children": [
{
"changeDescription": "Method \"checksumDryRun\" added",
"changeCode": "CE11",
"isBreaking": false,
"type": "minor"
}
]
},
{
"label": "Class LinkConfigImpl",
"children": [
{
"changeDescription": "Method \"checksumDryRun\" added",
"changeCode": "CE11",
"isBreaking": false,
"type": "minor"
}
]
}
]
}
} |
|
That seems to be a bug. Adding a |
Nevermind, we don't have static methods in extensions (yet). |
mosuem
reviewed
Jul 12, 2024
mosuem
approved these changes
Jul 12, 2024
pkgs/native_assets_builder/test/build_runner/build_runner_build_dry_run_test.dart
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test/build_runner/build_runner_build_dry_run_test.dart
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test/build_runner/build_runner_build_dry_run_test.dart
Outdated
Show resolved
Hide resolved
pkgs/native_assets_builder/test/build_runner/build_runner_caching_test.dart
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
native_assets_buildernow automatically treats all (transitive) Dart sources of a hook and the package_config.json as dependencies. This means the hook output no longer needs to list Dart sources as dependencies.The
native_assets_clidocumentation is updated to reflect this.The
native_toolchain_cCBuilderfield to list the Dart hook files have been deprecated.Testing
All Dart sources have been removed from the dependencies of the hooks.
pkgs/native_assets_builder/test/build_runner/build_runner_caching_test.dart already had a test for checking a hook output is not cached if the hook file itself is changed. This test passes now because the native assets builder lists all the Dart sources. The hook itself no longer reports itself as dependency in its output.
One weird quirk when testing is that we need to artificially leave some time between the
pub getand kernel compilation. It can be sub-second. And on Windows, the file timestamps only have second-precision. This means that if the dill file is compiled the same second as thepackage_config.jsonis written, the next invocation doesn't cache. By slowing the test down, we can test that in fact the second invocation is cached.Infra
dart compile kernel --depfileis only available on 3.5.0 dev releases. Sopackage:native_assets_buildercan no longer be run on the stable releases. This doesn't matter, because this package is pulled in to the last main/master for Flutter and Dart.