Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native_assets_builder] Speedup builds for 0 or 1 packages with native assets #129

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[native_assets_builder] Speedup builds for 0 or 1 packages with native assets #129

merged 2 commits into from
Sep 12, 2023

Conversation

dcharkes
Copy link
Collaborator

Closes: #128

@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:native_assets_builder 0.2.3 ready to publish native_assets_builder-v0.2.3
package:native_assets_cli 0.2.0 already published at pub.dev
package:native_toolchain_c 0.2.3 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

HosseinYousefi
HosseinYousefi approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dcharkes!

@dcharkes
Copy link
Collaborator Author

Thanks for the lightning speed review @HosseinYousefi ! ⚡

@auto-submit auto-submit bot merged commit 5177659 into main Sep 12, 2023
17 checks passed
@auto-submit auto-submit bot deleted the fast-plan branch September 12, 2023 15:54
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
@HosseinYousefi
[jnigen] added .filled ctor to JArray (#130)
0713d2e 
Closed #129.
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
@HosseinYousefi
[jnigen] added .filled ctor to JArray (#130)
1ca777f 
Closed #129.
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
[native_assets_builder] Speedup builds for 0 or 1 packages with nativ…
1b97a67 
…e assets (#129)

Closes: #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HosseinYousefi HosseinYousefi HosseinYousefi approved these changes

Assignees
No one assigned
Labels
autosubmit package:native_assets_builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[native_assets_builder] Don't compute topological order if it's not needed
2 participants
@dcharkes @HosseinYousefi