Skip to content

[native_assets_cli] Replace TypeErrors with FormatExceptions #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 7, 2023
Merged

[native_assets_cli] Replace TypeErrors with FormatExceptions #112

merged 4 commits into from
Aug 7, 2023

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Aug 7, 2023 •
edited
Loading

Closes #109.

Order of applying this fix:

  1. Merge this.
  2. (Merge [native_assets_cli] Rename Asset name to id #113.)
  3. Publish a new version of this package.
  4. Merge PR that bumps native_assets_cli in native_assets_builder pubspec.
  5. Push (and auto publish) v0.2.0 of native_assets_builder.

@dcharkes dcharkes requested a review from mkustermann August 7, 2023 12:16
@coveralls
Copy link

coveralls commented Aug 7, 2023 •
edited
Loading

Coverage Status

coverage: 98.458% (+0.004%) from 98.454%
when pulling 8f5380b on remove-casts
into b2b26db on main.

mkustermann
mkustermann approved these changes Aug 7, 2023
View reviewed changes
@dcharkes dcharkes merged commit 1b984c7 into main Aug 7, 2023
@dcharkes dcharkes deleted the remove-casts branch August 7, 2023 13:10
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
[native_assets_cli] Replace TypeErrors with FormatExceptions (#112)
cb8cb36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkustermann mkustermann mkustermann approved these changes

Assignees
No one assigned
Labels
package:hooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[native_assets_cli] Yaml parsing should throw FormatExceptions
3 participants
@dcharkes @coveralls @mkustermann