-
Notifications
You must be signed in to change notification settings - Fork 69
[native_assets_builder] Stop throwing from BuildRunner #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pkgs/native_assets_builder/lib/src/build_runner/build_runner.dart
Outdated
Show resolved
Hide resolved
@dcharkes given you want to rely on logging as side-channel for any build related info (what is being build, whether it was successful or not, reproduction instructions, timings, ...) it seems this PR isn't needed, is it? |
069662c
to
f9a4e35
Compare
I still think it's a good idea to return a success boolean rather than throwing and having call sites catch or write I'll rework the PR to do that instead. |
@mkustermann I've reworked the PR so that it doesn't throw any errors anymore and streams all errors to the logger. |
Thanks @mkustermann ! |
auto label is removed for dart-lang/native/108, due to - The status or check suite build (windows, stable, native_toolchain_c) has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Closes #106.
success
boolean.Closes #111.
build_output.yaml
to prevent caching on build failures. (See issue for alternative solutions.)