Repository navigation
[native_assets_cli] Remove OS and architecture from CodeAsset #2127
Copy link
Copy link
Closed
Description
Activity
Notes from discussion with @mkustermann:
- Do we need to consider future support for multi-architecture code assets before removing the OS/arch as output?
- If we want to ever add support for fat binaries, we'd probably want to add that as a
MultiArchCodeAssetwith aMultiArchCodeConfig- Which would have multiple architectures in the config.
- The
multi_architecture_code_assetshould be listed - Must the output contain all requested architectures? Or only a subset?
- If a subset, then it must be listed in the output.
- It would be a separate hook invocation.
- Open questions:
- How would that work together with the normal code assets? Can these be mixed and matched? Would Flutter for example combine a fat binary with two architectures and and a non-fat-binary with a single architecture if they have the same asset id?
- These
MultiArchitectureCodeAssets would likely live in the samepackage:code_assetssuch that they can shareOS,Architectureand friends.
- added a commit that references this issue
on Mar 26, 2025 - added a commit that references this issue
on Mar 27, 2025 The fields are no longer being red by newer hooks/SDKs.
They are still written for backwards compatibility, we can clean this up in a couple of weeks.
- added a commit that references this issue
on Apr 22, 2025 - added a commit that references this issue
on Jun 9, 2025 - added a commit that references this issue
on Aug 14, 2025
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
CodeAssets occur in an input or an output belonging to an input. We could simply remove the OS and architecture from the assets, because they must have the OS/architecture that is in the code config.