Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure console prints go through our shared outSink #4407

Merged
merged 1 commit into from
May 31, 2023
Merged

ensure console prints go through our shared outSink #4407

merged 1 commit into from
May 31, 2023

Conversation

pq
Copy link
Member

@pq pq commented May 31, 2023

Coralls leaked calls to print to reduce noise in test runs.

In anticipation of #4404

/cc @bwilkerson

@coveralls
Copy link

Coverage Status

Coverage: 96.843% (+0.0007%) from 96.842% when pulling b01c25e on tidy_printing into 91bd1be on main.

@pq pq merged commit b6c5657 into main May 31, 2023
@pq pq deleted the tidy_printing branch May 31, 2023 18:27
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
ensure console prints go through our shared outSink (dart-lang/lint…
a5e0c08 
…er#4407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pq @coveralls @bwilkerson