unreachable_from_main: Report unreachable constructors #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
force-pushed
the
unreachable-ctors-2
branch
from
bc2ef78
to
1e1050c
Compare
|
This is ready for review. |
bwilkerson
approved these changes
Mar 29, 2023
| static const LintCode code = LintCode('unreachable_from_main', | ||
| 'Unreachable top-level member in an executable library.', | ||
| static const LintCode code = LintCode( | ||
| 'unreachable_from_main', 'Unreachable member in an executable library.', |
There was a problem hiding this comment.
Consider adding the name of the member to the message for command-line users.
pq
added a commit
that referenced
this pull request
Apr 3, 2023
srawlins
added a commit
that referenced
this pull request
May 23, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
dart-lang/linter#4162)" (dart-lang/linter#4253)" (dart-lang/linter#4337) This reverts commit ed1dc5d. Also: Add support for test_reflective_loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for reporting unreachable constructors in
unreachable_from_main.UNUSED_ELEMENT.