Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename use_super_initializers to use_super_parameters #3288

Merged
merged 1 commit into from
Mar 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# 1.20.0

- renamed `use_super_initializers` to `use_super_parameters`
- fixed `unnecessary_null_aware_assignments` property-access
false positive

# 1.19.2

- new lint: `use_super_initializers`
Expand Down
2 changes: 1 addition & 1 deletion example/all.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ linter:
- use_rethrow_when_possible
- use_setters_to_change_properties
- use_string_buffers
- use_super_initializers
- use_super_parameters
- use_test_throws_matchers
- use_to_and_as_if_applicable
- valid_regexps
Expand Down
4 changes: 2 additions & 2 deletions lib/src/rules.dart
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ import 'rules/use_raw_strings.dart';
import 'rules/use_rethrow_when_possible.dart';
import 'rules/use_setters_to_change_properties.dart';
import 'rules/use_string_buffers.dart';
import 'rules/use_super_initializers.dart';
import 'rules/use_super_parameters.dart';
import 'rules/use_test_throws_matchers.dart';
import 'rules/use_to_and_as_if_applicable.dart';
import 'rules/valid_regexps.dart';
Expand Down Expand Up @@ -416,7 +416,7 @@ void registerLintRules({bool inTestMode = false}) {
..register(UseRawStrings())
..register(UseSettersToChangeAProperty())
..register(UseStringBuffers())
..register(UseSuperInitializers())
..register(UseSuperParameters())
..register(UseTestThrowsMatchers())
..register(UseToAndAsIfApplicable())
..register(ValidRegExps())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ class B extends A {
```
''';

class UseSuperInitializers extends LintRule {
class UseSuperParameters extends LintRule {
static const LintCode singleParam =
LintCode('use_super_initializers', "Convert '{0}' to a super parameter.");
LintCode('use_super_parameters', "Convert '{0}' to a super parameter.");
static const LintCode multipleParams =
LintCode('use_super_initializers', 'Convert {0} to super parameters.');
LintCode('use_super_parameters', 'Convert {0} to super parameters.');

UseSuperInitializers()
UseSuperParameters()
: super(
name: 'use_super_initializers',
name: 'use_super_parameters',
description: _desc,
details: _details,
maturity: Maturity.experimental,
Expand Down Expand Up @@ -230,10 +230,10 @@ class _Visitor extends SimpleAstVisitor {
if (identifiers.length > 1) {
var msg = identifiers.quotedAndCommaSeparatedWithAnd;
rule.reportLint(target,
errorCode: UseSuperInitializers.multipleParams, arguments: [msg]);
errorCode: UseSuperParameters.multipleParams, arguments: [msg]);
} else {
rule.reportLint(target,
errorCode: UseSuperInitializers.singleParam,
errorCode: UseSuperParameters.singleParam,
arguments: [identifiers.first]);
}
}
Expand Down
2 changes: 1 addition & 1 deletion lib/src/version.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
// BSD-style license that can be found in the LICENSE file.

/// Package version. Synchronized w/ pubspec.yaml.
const String version = '1.19.2';
const String version = '1.20.0';
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: linter
version: 1.19.2
version: 1.20.0

description: >-
The implementation of the lint rules supported by the analyzer framework.
Expand Down
4 changes: 2 additions & 2 deletions test/rules/all.dart
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ import 'unnecessary_overrides_test.dart' as unnecessary_overrides;
import 'use_enums_test.dart' as use_enums;
import 'use_is_even_rather_than_modulo_test.dart'
as use_is_even_rather_than_modulo;
import 'use_super_initializers_test.dart' as use_super_initializers;
import 'use_super_parameters_test.dart' as use_super_parameters;
import 'void_checks_test.dart' as void_checks;

void main() {
Expand Down Expand Up @@ -120,6 +120,6 @@ void main() {
unnecessary_overrides.main();
use_enums.main();
use_is_even_rather_than_modulo.main();
use_super_initializers.main();
use_super_parameters.main();
void_checks.main();
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@ import '../rule_test_support.dart';

main() {
defineReflectiveSuite(() {
defineReflectiveTests(UseSuperInitializersTest);
defineReflectiveTests(UseSuperParametersTest);
});
}

@reflectiveTest
class UseSuperInitializersTest extends LintRuleTest {
class UseSuperParametersTest extends LintRuleTest {
@override
List<String> get experiments => [
EnableString.super_parameters,
];

@override
String get lintRule => 'use_super_initializers';
String get lintRule => 'use_super_parameters';

test_named() async {
await assertDiagnostics(r'''
Expand All @@ -31,7 +31,7 @@ class B extends A {
const B({int? x, int? y}) : super(x: x, y: y);
}
''', [
lint('use_super_initializers', 69, 1),
lint('use_super_parameters', 69, 1),
]);
}

Expand Down Expand Up @@ -182,7 +182,7 @@ class B extends A {
B(int x, {int? foo}) : super(x, foo: 0);
}
''', [
lint('use_super_initializers', 59, 1),
lint('use_super_parameters', 59, 1),
]);
}

Expand All @@ -195,7 +195,7 @@ class B extends A {
B(int x) : super(x);
}
''', [
lint('use_super_initializers', 56, 1),
lint('use_super_parameters', 56, 1),
]);
}

Expand All @@ -208,7 +208,7 @@ class B extends A {
B([int x = 0]) : super(x);
}
''', [
lint('use_super_initializers', 46, 1),
lint('use_super_parameters', 46, 1),
]);
}

Expand All @@ -223,7 +223,7 @@ class C extends B {
C(int foo, int bar) : super(foo, bar);
}
''', [
lint('use_super_initializers', 93, 1),
lint('use_super_parameters', 93, 1),
]);
}

Expand All @@ -236,7 +236,7 @@ class B extends A {
B(int x, int y) : super(x, y: y);
}
''', [
lint('use_super_initializers', 56, 1),
lint('use_super_parameters', 56, 1),
]);
}

Expand All @@ -251,7 +251,7 @@ class C extends B {
C(int baz, int foo, int bar) : super(foo, bar);
}
''', [
lint('use_super_initializers', 93, 1),
lint('use_super_parameters', 93, 1),
]);
}

Expand All @@ -264,7 +264,7 @@ class B extends A {
B(int x, {int? y}) : super(x, y: y);
}
''', [
lint('use_super_initializers', 56, 1),
lint('use_super_parameters', 56, 1),
]);
}
}