Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _test suffix to rule tests #3228

Merged
merged 1 commit into from
Feb 11, 2022
Merged

add _test suffix to rule tests #3228

merged 1 commit into from
Feb 11, 2022

Conversation

pq
Copy link
Member

@pq pq commented Feb 11, 2022

/cc @bwilkerson

/fyi @DanTup

Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that we weren't being consistent. Good to see that we are now.

@pq
Copy link
Member Author

pq commented Feb 11, 2022

Yeah. @DanTup mentioned this and it surprised me too (especially since I'm the one who got us off on this inconsistent foot! 😬 )

@pq pq merged commit d5efd66 into master Feb 11, 2022
@pq pq deleted the test_renames branch February 11, 2022 17:54
@DanTup
Copy link
Contributor

DanTup commented Feb 11, 2022

Cool, thanks! 🙂

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.236% when pulling fb0875d on test_renames into acac694 on master.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants