Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

super_parameters support for tighten_type_of_initializing_formals #3167

Merged
merged 4 commits into from
Jan 24, 2022
Merged

super_parameters support for tighten_type_of_initializing_formals #3167

merged 4 commits into from
Jan 24, 2022

Conversation

pq
Copy link
Member

@pq pq commented Jan 20, 2022

See: #3131

/cc @bwilkerson

@pq pq mentioned this pull request Jan 20, 2022
Closed
14 tasks
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 94.182% when pulling 24f71a7 on tighten_type_of_initializing_formals_super into 5acea57 on master.

bwilkerson
bwilkerson approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have the changes from two PRs intermixed. I think I commented on the first set separately, but I think the changes for tighten_type_of_initializeing_formals looks right.

@pq pq merged commit f04d3e0 into master Jan 24, 2022
@pq pq deleted the tighten_type_of_initializing_formals_super branch January 24, 2022 20:45
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
super_parameters support for tighten_type_of_initializing_formals (d…
1535773 
…art-lang/linter#3167)

* super_parameter support for `avoid_annotating_with_dynamic`

* fmt

* whoops

* super_parameters support for `tighten_type_of_initializing_formals`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pq @coveralls @bwilkerson