tidy shared test setup (#4405)

* tidy shared test setup * fix
dart-lang · May 30, 2023 · 6d9e080 · 6d9e080
1 parent 0b1eadf
commit 6d9e080
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 5 deletions.
diff --git a/test/doc_test.dart b/test/doc_test.dart
@@ -5,9 +5,11 @@
 import 'package:test/test.dart';
 
 import '../tool/doc.dart';
+import 'util/test_utils.dart';
 
 void main() {
   group('doc generation', () {
+    setUp(setUpSharedTestEnvironment);
     test('fixStatus (sanity)', () async {
       var fixStatusMap = await fetchFixStatusMap();
       // Doc generation reads the fix status map to associate fix status

diff --git a/test/engine_test.dart b/test/engine_test.dart
@@ -19,6 +19,7 @@ import 'package:test/test.dart';
 
 import 'mocks.dart';
 import 'test_constants.dart';
+import 'util/test_utils.dart';
 
 void main() {
   defineLinterEngineTests();
@@ -27,6 +28,7 @@ void main() {
 /// Linter engine tests
 void defineLinterEngineTests() {
   group('engine', () {
+    setUp(setUpSharedTestEnvironment);
     group('reporter', () {
       void doTest(
           String label, String expected, Function(PrintingReporter r) report) {

diff --git a/test/rule_test.dart b/test/rule_test.dart
@@ -33,10 +33,13 @@ import 'util/annotation_matcher.dart';
 import 'util/test_utils.dart';
 
 void main() {
-  defineSanityTests();
-  defineRuleTests();
-  experiment_tests.main();
-  defineRuleUnitTests();
+  group('rule tests', () {
+    setUp(setUpSharedTestEnvironment);
+    defineSanityTests();
+    defineRuleTests();
+    experiment_tests.main();
+    defineRuleUnitTests();
+  });
 }
 
 /// Rule tests

diff --git a/test/util/test_utils.dart b/test/util/test_utils.dart
@@ -1,9 +1,18 @@
 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
-
+import 'package:analyzer/src/lint/io.dart';
+import 'package:linter/src/rules.dart';
 import 'package:test/test.dart';
 
+import '../mocks.dart';
+
+void setUpSharedTestEnvironment() {
+  // Redirect output.
+  outSink = MockIOSink();
+  registerLintRules();
+}
+
 void testEach<T>(Iterable<T> values, bool Function(T s) f, Matcher m) {
   for (var s in values) {
     test('"$s"', () => expect(f(s), m));

diff --git a/test/validate_rule_description_format_test.dart b/test/validate_rule_description_format_test.dart
@@ -5,6 +5,8 @@
 import 'package:analyzer/src/lint/registry.dart';
 import 'package:test/test.dart';
 
+import 'util/test_utils.dart';
+
 void main() {
   const keywords = [
     'GOOD',
@@ -16,6 +18,8 @@ void main() {
   ];
 
   group('rule doc format', () {
+    setUp(setUpSharedTestEnvironment);
+
     var rules = Registry.ruleRegistry.rules;
     test('(setup)', () {
       expect(rules, isNotEmpty,