Integrate with DevTools. #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderDake
reviewed
Dec 5, 2022
| const String memoryLeakTrackingExtensionName = 'ext.dart.memoryLeakTracking'; | ||
|
|
||
| /// Version of protocol, executed by the application. | ||
| const String appLeakTrackerProtocolVersion = '1'; |
There was a problem hiding this comment.
Will this be important for caching?
It may be worth using semver in case we ever need to release incremental patches/fixes etc.
Contributor
Author
There was a problem hiding this comment.
Protocol versions are different from software versions. They normally flip by 1.
I do not expect we will need to support more than two versions of protocol in DevTools.
Anyway, I suggest to figure it out when we decide to introduce breaking changes.
Co-authored-by: Daniel Chevalier <danchevalier@google.com>
Co-authored-by: Daniel Chevalier <danchevalier@google.com>
Co-authored-by: Daniel Chevalier <danchevalier@google.com>
Co-authored-by: Daniel Chevalier <danchevalier@google.com>
Co-authored-by: Daniel Chevalier <danchevalier@google.com>
Co-authored-by: Daniel Chevalier <danchevalier@google.com>
Co-authored-by: Daniel Chevalier <danchevalier@google.com>
CoderDake
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer draft in DevTools: flutter/devtools#4891
Screen.Recording.2022-12-03.at.11.11.55.PM.mov