Skip to content

Fix bug in ObjectMetadata.replace -- release gcloud #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix bug in ObjectMetadata.replace -- release gcloud #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/gcloud/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.8.17
- Fix bug in `ObjectMetadata.replace` where `contentEncoding` overwrote
`contentDisposition` and `contentLanguage`.

## 0.8.16

- `BucketEntry` is now `sealed` this may cause **breakage** for anyone
Expand Down
4 changes: 2 additions & 2 deletions pkgs/gcloud/lib/src/storage_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,8 +514,8 @@ class _ObjectMetadata implements ObjectMetadata {
contentType: contentType ?? this.contentType,
contentEncoding: contentEncoding ?? this.contentEncoding,
cacheControl: cacheControl ?? this.cacheControl,
contentDisposition: contentDisposition ?? this.contentEncoding,
contentLanguage: contentLanguage ?? this.contentEncoding,
contentDisposition: contentDisposition ?? this.contentDisposition,
contentLanguage: contentLanguage ?? this.contentLanguage,
custom: custom != null ? Map.from(custom) : this.custom);
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkgs/gcloud/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: gcloud
version: 0.8.16
version: 0.8.17
description: >-
High level idiomatic Dart API for Google Cloud Storage, Pub-Sub and Datastore.
repository: https://github.com/dart-lang/labs/tree/main/pkgs/gcloud
Expand Down