Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Jun 30, 2025

And prep for publish.

The large diff is due to the formatting update, there are no real changes made apart from dart format, dart fix, and a couple manual analysis error fixes.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions
Copy link

github-actions bot commented Jun 30, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:intl 0.20.3-wip WIP (no publish necessary)
package:intl4x 0.13.0 already published at pub.dev
package:intl_translation 0.21.0 ready to publish intl_translation-v0.21.0
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions
Copy link

github-actions bot commented Jun 30, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

@mosuem mosuem requested a review from devoncarew June 30, 2025 12:36
@mosuem mosuem marked this pull request as ready for review June 30, 2025 12:38
Copy link
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The amount of formatting changes from 3.6 => 3.7 are really pretty large (here, and for other projects I've seen).

@Peetee06
Copy link
Contributor

hey @mosuem can I support here in some way to get this merged and intl_translation released? :)

@Peetee06
Copy link
Contributor

@mosuem friendly ping. :)

Happy to resolve the conflicts for you if that helps. Just let me know.

@Vlad-Adrian
Copy link

hello, just a short ping for this release.

I am more than happy to help with anything, just let me know the plan.

@Peetee06
Copy link
Contributor

@mosuem this just became a major blocker for us.

We can’t upgrade to Flutter 3.35.1, because of dependency conflicts that stem from the outdated dart_style constraint.

I’m looking into ways around this but please let’s get this released 🙏

@devoncarew maybe you can ping @mosuem ?

@Peetee06
Copy link
Contributor

@robertbastian maybe you know something? I saw you take over another PR from @mosuem

@robertbastian
Copy link
Collaborator

no

@mosuem
Copy link
Member Author

mosuem commented Aug 19, 2025

Sorry, a lot going on at the moment.

@mosuem mosuem force-pushed the publishIntlTranslation branch from 9094901 to c742504 Compare August 19, 2025 14:18
@mosuem mosuem force-pushed the publishIntlTranslation branch from c742504 to bb7ae5e Compare August 19, 2025 14:22
@Vlad-Adrian
Copy link

hey @mosuem, is there a timeline for these changes to be merged?

@mosuem
Copy link
Member Author

mosuem commented Sep 18, 2025

I'm back from vacation and on it! Hopefully today, if there are no problems internally. Otherwise I'll have to fix those first...

copybara-service bot pushed a commit that referenced this pull request Sep 19, 2025
--
bb7ae5e by Moritz <mosum@google.com>:

upgrade sdl

--
99ca13b by Moritz <mosum@google.com>:

Update

--
f56e144 by Moritz <mosum@google.com>:

Updates

--
f4ca2c9 by Moritz <mosum@google.com>:

Add exports

--
b67c481 by Moritz <mosum@google.com>:

Fixes

COPYBARA_INTEGRATE_REVIEW=#983 from dart-lang:publishIntlTranslation b67c481
PiperOrigin-RevId: 808992050
@mosuem mosuem merged commit f171926 into main Sep 19, 2025
10 checks passed
@mosuem mosuem deleted the publishIntlTranslation branch September 19, 2025 15:35
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 1, 2025
…it_inspection_protocol

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/901e2ce..ec5d6aa):
  ec5d6aa  2025-10-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/ai#288)

http (https://github.com/dart-lang/http/compare/e0dadd1..2c53fa3):
  2c53fa3  2025-10-01  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/http#1828)
  1b5103f  2025-10-01  Alex Li  [cronet_http] Upgrade `cronet-embedded` dependency version to support 16 KB page sizes (dart-lang/http#1824)
  f701e93  2025-09-29  Brian Quinlan  Remove obsolete TODO comment (dart-lang/http#1816)

i18n (https://github.com/dart-lang/i18n/compare/09627d2..34d1832):
  34d1832b  2025-10-01  Moritz  Fix casemapping on web (dart-lang/i18n#1013)
  914b0178  2025-10-01  dependabot[bot]  Bump actions/labeler from 5.0.0 to 6.0.1 in the github-actions group (dart-lang/i18n#1014)
  f171926e  2025-09-19  Moritz  Upgrade SDK in package:intl_translation (dart-lang/i18n#983)

shelf (https://github.com/dart-lang/shelf/compare/de91a5b..f30d650):
  f30d650  2025-10-01  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/shelf#483)

test (https://github.com/dart-lang/test/compare/b99d556..a16f149):
  a16f1497  2025-10-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/test#2547)

tools (https://github.com/dart-lang/tools/compare/2ef298e..19f91a0):
  19f91a03  2025-10-01  Morgan :)  Run file watcher symlink tests. (dart-lang/tools#2189)
  7929379b  2025-10-01  Morgan :)  Add test coverage for file watcher and symlinks. (dart-lang/tools#2178)
  d0e3edd1  2025-09-30  Morgan :)  Fix file watcher startup race on MacOS (dart-lang/tools#2176)
  36cefcee  2025-10-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/tools#2188)
  08db1688  2025-10-01  Aleksey Garbarev  Fixing structure issue of nested lists indented by tabs (`#2172`) (dart-lang/tools#2173)
  16276f53  2025-09-30  Parker Lougheed  [markdown] Simplify deindentation logic for fenced code block lines (dart-lang/tools#2187)

vector_math (https://github.com/google/vector_math.dart/compare/3939545..a7b7e9c):
  a7b7e9c  2025-10-01  dependabot[bot]  Bump the github-actions group with 2 updates (google/vector_math.dart#352)

web (https://github.com/dart-lang/web/compare/0baaea4..816abcc):
  816abcc  2025-10-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/web#473)

webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/effa752..0f76858):
  0f76858  2025-10-01  dependabot[bot]  Bump the github-actions group across 1 directory with 3 updates (google/webkit_inspection_protocol.dart#135)

Change-Id: Id2cf6c1142aece53d531ca46122bb36a0fa2a34b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/452902
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants