Skip to content

Conversation

@mosuem
Copy link
Member

@mosuem mosuem commented Aug 6, 2025

Fixes #989


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 6, 2025
@github-actions
Copy link

github-actions bot commented Aug 6, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
intl4x Breaking 0.12.2 0.13.0-wip 0.13.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/intl4x/hook/link.dart 💔 Not covered
pkgs/intl4x/lib/case_mapping.dart 💚 100 %
pkgs/intl4x/lib/intl4x.dart 💚 100 %
pkgs/intl4x/lib/src/case_mapping/case_mapping.dart 💚 82 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@mosuem mosuem added the autosubmit Merge PR when tree becomes green via Auto Submit App label Aug 6, 2025
@mosuem mosuem added autosubmit Merge PR when tree becomes green via Auto Submit App and removed autosubmit Merge PR when tree becomes green via Auto Submit App labels Aug 7, 2025
@mosuem mosuem merged commit 25cdb1b into main Aug 7, 2025
73 checks passed
@mosuem mosuem deleted the reenableMac branch August 7, 2025 12:26
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 7, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/414953e..82b48b5):
  82b48b53  2025-08-05  István Soós  Update highlight.js download instructions and resources. (dart-lang/dartdoc#4081)

ecosystem (https://github.com/dart-lang/ecosystem/compare/2fe3618..4543c38):
  4543c38  2025-08-06  Devon Carew  address a `Bad state: No element` element exception (dart-lang/ecosystem#321)
  e14472f  2025-08-06  Devon Carew  add a roadmap to our various mono-repos (dart-lang/ecosystem#318)
  e83479a  2025-08-06  Moritz  Fixes to health (dart-lang/ecosystem#363)
  552f534  2025-08-06  Moritz  Update API tool hash (dart-lang/ecosystem#362)

i18n (https://github.com/dart-lang/i18n/compare/c45e050..25cdb1b):
  25cdb1b4  2025-08-07  Moritz  Reenable mac size checks (dart-lang/i18n#1001)

shelf (https://github.com/dart-lang/shelf/compare/082d3ac..2a46b4f):
  2a46b4f  2025-08-05  Kevin Moore  Update dependencies across 3 packages (dart-lang/shelf#479)

test (https://github.com/dart-lang/test/compare/5aef971..9354f23):
  9354f239  2025-08-07  Liam Appelbe  Add `--coverage-path` and `--branch-coverage` options (dart-lang/test#2517)

tools (https://github.com/dart-lang/tools/compare/5e977d6..1b52e89):
  1b52e89e  2025-08-06  Moritz  Configure Gemini code review (dart-lang/tools#2141)

web (https://github.com/dart-lang/web/compare/1d5771b..f3c960f):
  f3c960f  2025-08-06  Nikechukwu  [web_generator] Add support for passing files as globs (dart-lang/web#427)
  f51cc85  2025-08-06  Nikechukwu  [interop] Add Support for Namespaces (dart-lang/web#436)

webdev (https://github.com/dart-lang/webdev/compare/7ff2d07..94c172c):
  94c172cc  2025-08-05  Nicholas Shahan  Wait for any remaining output in e2e_test.dart (dart-lang/webdev#2663)

Change-Id: Ie18635903f7379bc27e7ae23b916e10e4bdcef94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444360
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 7, 2025
… webdev"

This reverts commit 00240e8.

Reason for revert: failures on HHH

Original change's description:
> [deps] rev dartdoc, ecosystem, i18n, shelf, test, tools, web, webdev
>
> Revisions updated by `dart tools/rev_sdk_deps.dart`.
>
> dartdoc (https://github.com/dart-lang/dartdoc/compare/414953e..82b48b5):
>   82b48b53  2025-08-05  István Soós  Update highlight.js download instructions and resources. (dart-lang/dartdoc#4081)
>
> ecosystem (https://github.com/dart-lang/ecosystem/compare/2fe3618..4543c38):
>   4543c38  2025-08-06  Devon Carew  address a `Bad state: No element` element exception (dart-lang/ecosystem#321)
>   e14472f  2025-08-06  Devon Carew  add a roadmap to our various mono-repos (dart-lang/ecosystem#318)
>   e83479a  2025-08-06  Moritz  Fixes to health (dart-lang/ecosystem#363)
>   552f534  2025-08-06  Moritz  Update API tool hash (dart-lang/ecosystem#362)
>
> i18n (https://github.com/dart-lang/i18n/compare/c45e050..25cdb1b):
>   25cdb1b4  2025-08-07  Moritz  Reenable mac size checks (dart-lang/i18n#1001)
>
> shelf (https://github.com/dart-lang/shelf/compare/082d3ac..2a46b4f):
>   2a46b4f  2025-08-05  Kevin Moore  Update dependencies across 3 packages (dart-lang/shelf#479)
>
> test (https://github.com/dart-lang/test/compare/5aef971..9354f23):
>   9354f239  2025-08-07  Liam Appelbe  Add `--coverage-path` and `--branch-coverage` options (dart-lang/test#2517)
>
> tools (https://github.com/dart-lang/tools/compare/5e977d6..1b52e89):
>   1b52e89e  2025-08-06  Moritz  Configure Gemini code review (dart-lang/tools#2141)
>
> web (https://github.com/dart-lang/web/compare/1d5771b..f3c960f):
>   f3c960f  2025-08-06  Nikechukwu  [web_generator] Add support for passing files as globs (dart-lang/web#427)
>   f51cc85  2025-08-06  Nikechukwu  [interop] Add Support for Namespaces (dart-lang/web#436)
>
> webdev (https://github.com/dart-lang/webdev/compare/7ff2d07..94c172c):
>   94c172cc  2025-08-05  Nicholas Shahan  Wait for any remaining output in e2e_test.dart (dart-lang/webdev#2663)
>
> Change-Id: Ie18635903f7379bc27e7ae23b916e10e4bdcef94
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444360
> Auto-Submit: Devon Carew <devoncarew@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I239eff7add9e5432c67b05c8f7731e1a79d4e4db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444387
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 8, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/414953e..82b48b5):
  82b48b53  2025-08-05  István Soós  Update highlight.js download instructions and resources. (dart-lang/dartdoc#4081)

ecosystem (https://github.com/dart-lang/ecosystem/compare/2fe3618..4543c38):
  4543c38  2025-08-06  Devon Carew  address a `Bad state: No element` element exception (dart-lang/ecosystem#321)
  e14472f  2025-08-06  Devon Carew  add a roadmap to our various mono-repos (dart-lang/ecosystem#318)
  e83479a  2025-08-06  Moritz  Fixes to health (dart-lang/ecosystem#363)
  552f534  2025-08-06  Moritz  Update API tool hash (dart-lang/ecosystem#362)

i18n (https://github.com/dart-lang/i18n/compare/c45e050..25cdb1b):
  25cdb1b4  2025-08-07  Moritz  Reenable mac size checks (dart-lang/i18n#1001)

shelf (https://github.com/dart-lang/shelf/compare/082d3ac..2a46b4f):
  2a46b4f  2025-08-05  Kevin Moore  Update dependencies across 3 packages (dart-lang/shelf#479)

tools (https://github.com/dart-lang/tools/compare/5e977d6..1b52e89):
  1b52e89e  2025-08-06  Moritz  Configure Gemini code review (dart-lang/tools#2141)

web (https://github.com/dart-lang/web/compare/1d5771b..f3c960f):
  f3c960f  2025-08-06  Nikechukwu  [web_generator] Add support for passing files as globs (dart-lang/web#427)
  f51cc85  2025-08-06  Nikechukwu  [interop] Add Support for Namespaces (dart-lang/web#436)

webdev (https://github.com/dart-lang/webdev/compare/7ff2d07..94c172c):
  94c172cc  2025-08-05  Nicholas Shahan  Wait for any remaining output in e2e_test.dart (dart-lang/webdev#2663)

Change-Id: Id553d989bdb5aea483e6ad7d955a965cfaa3cf16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444362
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via Auto Submit App package:intl4x type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mac binary size is too large

3 participants