Fixes #293, added property url to BaseResponse. related work(#321) #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have to be careful adding APIs here – they are breaking for common base classes. |
|
I very much agree with that opinion. As a matter of urgency, I'm going to use my own forked PATCH to get by, so no problem. |
|
I think the main way this is breaking is for stubbed requests, I've found at least one case where I think if we find it's only breaking for test code it may be OK to go forward with this change anyway, but we'll have to be careful during the rollout. |
natebosch
added a commit
that referenced
this pull request
May 25, 2022
Closes #321, closes #623, closes #692 Fixes #293 Add a Uri field to BaseResponse with the final, potentially redirected, url for the content. The field is nullable for backwards compatibility - TODO: consider if this should be non-nullable from the start, or if it can be published nullable first and become non-nullable (and the constructor arg required) in the next breaking release. This may break tests which use bocks but do not mock the field used to read the URL.
Closed
|
If we are able to roll out this feature I think we'll use a |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost a copy of this Pull Request #321.
Additional work includes support for Null Safety and tests created from streams.
I've create new patch, since the original author @yizhepku mention the following in #293.
If there are any deficiencies in this pull request, please let me know so I could take additional action.