Skip to content

Clarify that some headers may not be sent/received #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/http/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.4.1

* Clarify that some header names may not be sent/received.

## 1.4.0

* Fixed default encoding for application/json without a charset
Expand Down
8 changes: 7 additions & 1 deletion pkgs/http/lib/src/base_request.dart
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,13 @@ abstract class BaseRequest {

// TODO(nweiz): automatically parse cookies from headers

// TODO(nweiz): make this a HttpHeaders object
/// The HTTP headers sent to the server.
///
/// Header names are converted to lowercase when sent to the server.
///
/// Some headers may not be sent by the [Client] for security or privacy
/// reasons. For example, browser-based clients may only sent headers in the
/// CORS safelist or specifically allowed by the server.
final Map<String, String> headers;

/// Whether [finalize] has been called.
Expand Down
4 changes: 4 additions & 0 deletions pkgs/http/lib/src/base_response.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ abstract class BaseResponse {
/// If a header value contains whitespace then that whitespace may be replaced
/// by a single space. Leading and trailing whitespace in header values are
/// always removed.
///
/// Some headers may be excluded by the [Client] for security or privacy
/// reasons. For example, browser-based clients can only return headers in the
/// CORS safelist or specifically allowed by the server.
final Map<String, String> headers;

final bool isRedirect;
Expand Down
2 changes: 1 addition & 1 deletion pkgs/http/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: http
version: 1.4.0
version: 1.4.1-wip
description: A composable, multi-platform, Future-based API for HTTP requests.
repository: https://github.com/dart-lang/http/tree/master/pkgs/http

Expand Down
Loading