[http_client_conformance_tests] server headers invalid headers values CR on FireFox

[Zekfad]

In process of testing fetch_client I've found that FireFox doesn't populate invalid header with carriage return, which causes failure of following test in FF:

server headers invalid headers values CR

http/pkgs/http_client_conformance_tests/lib/src/response_headers_tests.dart

Lines 181 to 184 in 29c5733

	'1 2', // RFC-specified behavior
	// Common client behavior (Cronet, Apple URL Loading System).
	'1',
	'1\r2', // Common client behavior (Java).

I've got following errors:

01:36 +452 ~72 -1: [Firefox, Dart2Js] test\client_conformance_test.dart: client conformance tests server headers invalid headers values CR [E]
  Expected: ('1 2' or '1' or '1\r2')
    Actual: <null>

02:30 +547 ~108 -2: [Firefox, Dart2Wasm] test\client_conformance_test.dart: client conformance tests server headers invalid headers values CR [E]
  Expected: ('1 2' or '1' or '1\r2')
    Actual: <null>

03:38 +607 ~116 -3: [Firefox, Dart2Js] test\client_conformance_test.dart: client conformance tests with probe mode server headers invalid headers values CR [E]
  Expected: ('1 2' or '1' or '1\r2')
    Actual: <null>

05:52 +719 ~141 -4: [Firefox, Dart2Js] test\client_conformance_test.dart: client conformance tests with probeHead mode server headers invalid headers values CR [E]
  Expected: ('1 2' or '1' or '1\r2')
    Actual: <null>

06:10 +729 ~141 -5: [Firefox, Dart2Wasm] test\client_conformance_test.dart: client conformance tests with probe mode server headers invalid headers values CR [E]
  Expected: ('1 2' or '1' or '1\r2')
    Actual: <null>

09:49 +816 ~168 -6: [Firefox, Dart2Wasm] test\client_conformance_test.dart: client conformance tests with probeHead mode server headers invalid headers values CR [E]
  Expected: ('1 2' or '1' or '1\r2')
    Actual: <null>

Not sure what to do here. The only possible way I see is to add null as a valid behavior, since it's impossible to get the raw data from response on web.

[brianquinlan]

I see the same issue when I run dart test -p firefox in the package:http repro. I'll create a PR that:

1. allows null as a value
2. runs our tests using firefox

I think that this is a bug - do you want to file a Firefox bug?

[brianquinlan]

Fixed in #1762

[Zekfad]

Thank you for resolving this!

This behavior does seem contradictory to mentioned RFC, I haven't used bugzilla, so if you're already familiar with Firefox issue tracker, you could submit this matter.