Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concerns about the usage of --dart-define in gradle scripts #1267

Open
vanyasem opened this issue Jul 14, 2024 · 0 comments
Open

Concerns about the usage of --dart-define in gradle scripts #1267

vanyasem opened this issue Jul 14, 2024 · 0 comments
Assignees
Labels
package:cronet_http type-enhancement A request for a change that isn't a bug

Comments

@vanyasem
Copy link

In #1111, it was decided to use dart-define to determine dependency, and it's used in build.gradle: https://github.com/dart-lang/http/pull/1111/files#diff-7eec577c9e03d491b0cd36f6123f52011707d1c3e96bce8ce875629a057f4046

As discussed in flutter/flutter#136865 (comment), the fact that --dart-define happens to provide it's value to gradle is an undocumented implementation detail, and should not be relied upon

The issue for the implementation of a proper way to pass params to native build tools is located here: flutter/flutter#139289

Some additional context can be found here: flutter/flutter#138793

@vanyasem vanyasem added package:cronet_http type-enhancement A request for a change that isn't a bug labels Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:cronet_http type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants