Skip to content

Bump to analyzer 6.1.0 #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Bump to analyzer 6.1.0 #3474

merged 2 commits into from
Aug 8, 2023

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Aug 6, 2023

No description provided.

@srawlins srawlins requested a review from scheglov August 6, 2023 22:44
@@ -16380,6 +16380,8 @@ const _invisibleGetters = {
'runtimeType'
},
'ClassElement': {
'augmentation',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it used? These methods are marked @experimental, meaning that we would not like clients to use them yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the README for mustachio. Every property of important classes is enumerated here; it is not hand-picked properties, but every property.

We can update the generator to exclude @experimental properties.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now I understand that these are generated.
I think we should not using experimental properties outside of the analyzer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I worry is that if we change these getters in the analyzer, this will break dartdoc.
If this is not an issue, we can land this of course.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I missed where this is used. This is in the list of "invisible getters", so they cannot be used in the runtime renderers. An error is reported if an attempt is made to access this field.

@srawlins
Copy link
Member Author

srawlins commented Aug 8, 2023

They're not used. They're just made available. I can change the generator in a follow-up PR to not include @experimental properties.

@srawlins
Copy link
Member Author

srawlins commented Aug 8, 2023

It's not a fun API. Everytime a getter is added or removed (even if it is never used), the generated code must be re-generated.

@srawlins srawlins merged commit 5cfb1f3 into dart-lang:main Aug 8, 2023
@srawlins srawlins deleted the analyzer-6-1 branch August 8, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants