-
Notifications
You must be signed in to change notification settings - Fork 125
Bump to analyzer 6.1.0 #3474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to analyzer 6.1.0 #3474
Conversation
@@ -16380,6 +16380,8 @@ const _invisibleGetters = { | |||
'runtimeType' | |||
}, | |||
'ClassElement': { | |||
'augmentation', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is it used? These methods are marked @experimental
, meaning that we would not like clients to use them yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the README for mustachio. Every property of important classes is enumerated here; it is not hand-picked properties, but every property.
We can update the generator to exclude @experimental
properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now I understand that these are generated.
I think we should not using experimental properties outside of the analyzer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I worry is that if we change these getters in the analyzer, this will break dartdoc
.
If this is not an issue, we can land this of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, I missed where this is used. This is in the list of "invisible getters", so they cannot be used in the runtime renderers. An error is reported if an attempt is made to access this field.
They're not used. They're just made available. I can change the generator in a follow-up PR to not include |
It's not a fun API. Everytime a getter is added or removed (even if it is never used), the generated code must be re-generated. |
No description provided.