Skip to content

Convert Tuples to Records and split a helper out from findCanonicalModelElementFor #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Jun 7, 2023

No description provided.

@parlough
Copy link
Member

parlough commented Jun 7, 2023

I've been looking forward to that tuple file disappearing for a long time 🥳

@srawlins srawlins requested a review from jcollins-g June 7, 2023 15:12
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -1,56 +0,0 @@
// Copied from source at github.com/kseo/tuple/blob/470ed3aeb/lib/src/tuple.dart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉

Haha!

@srawlins srawlins merged commit d5bb24b into dart-lang:main Jun 7, 2023
@srawlins srawlins deleted the tuple-to-records2 branch June 7, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants