Skip to content

Add testing for constructor tearoffs constant rendering. #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jcollins-g
Copy link
Contributor

Fixes #2655.

It looks like constant rendering is at least of similar quality to other features as-is for constructor tearoffs. There is one aspect of passing arguments that does not work yet but may work soon with a newer analyzer.

This is the last bit of planned work for constructor tearoffs for dartdoc, so marking it as fixing the issue. We will have to maintain this feature as the analyzer implementation changes. We also may yet discover more work and will reopen if need be.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Sep 10, 2021
@jcollins-g jcollins-g requested a review from srawlins September 10, 2021 20:37
@jcollins-g jcollins-g merged commit 51776f2 into dart-lang:master Sep 11, 2021
@jcollins-g jcollins-g deleted the constructor-tearoffs-const-rendering branch September 11, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement constructor tear-offs in dartdoc
2 participants