Fix parameter and type issues with head analyzer #2687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
withdrawing for now, looks to have been triggered by a more extensive change |
jcollins-g
changed the title
srawlins
approved these changes
Jun 18, 2021
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 18, 2021
This reverts commit fa303eb. Reason for revert: This breaks dartdoc until dart-lang/dartdoc#2687 can roll to analyzer. Original change's description: > Keep libraries after linking, don't reload from bytes. > > Presubmit in google3 looks green. > https://test.corp.google.com/ui#id=OCL:376412203:BASE:379875911:1623903883365:2a59d852 > > Change-Id: I344d49fa12e2f07aa00623ea08e7530872ca2eec > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201661 > Reviewed-by: Samuel Rawlins <srawlins@google.com> > Commit-Queue: Konstantin Shcheglov <scheglov@google.com> # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I6eeee8b6f480a6ac5c2665e5844f04788c1174a4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204263 Commit-Queue: Janice Collins <jcollins@google.com> Commit-Queue: Devon Carew <devoncarew@google.com> Auto-Submit: Janice Collins <jcollins@google.com> Reviewed-by: Devon Carew <devoncarew@google.com>
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 21, 2021
This used to be the case when we read element model from bytes. But we started (accidentally) providing it when keeping linking elements. This caused https://dart-review.googlesource.com/c/sdk/+/201661 to be reverted. There is a work around in dartdoc, to be pulled into SDK. dart-lang/dartdoc#2687 This CL hopefully fixes the issue. Change-Id: Ib1a952085a80c4673baab01a6c4e4a30c1a8ea73 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204360 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes to head analyzer: