Skip to content

Fix for a duplicate nullability suffix in Md renderers #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2021

Conversation

VladimirBrejcha
Copy link
Contributor

@VladimirBrejcha VladimirBrejcha commented Apr 29, 2021

It seems to me that this line:

buf.write(elementType.nullabilitySuffix);

adds nullabilitySuffix to the string, and then this line:

wrapNullability(elementType, buf.toString());

which leads to:

String wrapNullability(T elementType, String inner) =>
      '$inner${elementType.nullabilitySuffix}';

that does exactly the same, which results in duplicate nullability suffix in the resulting string

…m AliasedElementTypeRendererMd and ParameterizedElementTypeRendererMd
@google-cla
Copy link

google-cla bot commented Apr 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 29, 2021
@VladimirBrejcha
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Google CLA check succeeded. and removed cla: no labels Apr 29, 2021
@jcollins-g
Copy link
Contributor

Thanks for your contribution, and yep, this looks like a bug! Will approve/merge once all the checks go green.

@jcollins-g
Copy link
Contributor

@VladimirBrejcha It looks like this PR may need an update from head to pass; some changes in the dev SDK required some commits to dartdoc.

@VladimirBrejcha
Copy link
Contributor Author

@jcollins-g I merged latest changes from master

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 57.572% when pulling 0447df5 on VladimirBrejcha:master into 3d990ca on dart-lang:master.

@jcollins-g jcollins-g merged commit de5c302 into dart-lang:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants