Skip to content

Put late before final in feature sorting #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2021
Merged

Put late before final in feature sorting #2608

merged 1 commit into from
Apr 8, 2021

Conversation

jcollins-g
Copy link
Contributor

Also, do not mark late fields/variables as "read-write". While that's technically true depending on your point of view, the word "late" encapsulates the behavior more accurately.

before:

Screen Shot 2021-04-07 at 12 19 55 PM

after:

Screen Shot 2021-04-07 at 12 19 42 PM

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Apr 7, 2021
@jcollins-g jcollins-g requested a review from srawlins April 7, 2021 19:56
srawlins
srawlins approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches.

@jcollins-g jcollins-g merged commit 837d112 into dart-lang:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcollins-g @srawlins