Skip to content

write out static methods on extensions #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2021
Merged

write out static methods on extensions #2591

merged 2 commits into from
Mar 29, 2021

Conversation

jcollins-g
Copy link
Contributor

Fixes #2588. Drops a test that verified we wrote the wrong broken link if someone wrote out a wrong broken link, which isn't something we really need, in favor of enabling link validation on the test package.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Mar 25, 2021
@jcollins-g jcollins-g requested a review from srawlins March 25, 2021 23:07
@coveralls
Copy link

coveralls commented Mar 25, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 91.298% when pulling 952ec99 on jcollins-g:static-methods-extensions into 8b911bc on dart-lang:master.

@jcollins-g jcollins-g merged commit fcd50e7 into dart-lang:master Mar 29, 2021
@jcollins-g jcollins-g deleted the static-methods-extensions branch March 29, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files documenting static extension methods are not generated.
3 participants
@jcollins-g @coveralls @srawlins