Make modelType/ElementType usage more consistent #2573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2226.
BREAKING CHANGE : this removes the
linkedReturnTypeaccessor which previously accessed not only function return types, but types of constants and other non-callables. This cleans things up so that if you're looking for a return type, you ask for one, and if you don't want a return type, you don't ask for one. A side effect is that some of the errant span classes claiming return types were parameters are now fixed as well.With this cleanup it should be possible to deconstruct
ModelElement.modelTypeand implement the relevant pieces in subclasses.