Skip to content

Mustachio: add properties from mixins not found in a Renderer #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2021
Merged

Mustachio: add properties from mixins not found in a Renderer #2568

merged 1 commit into from
Mar 10, 2021

Conversation

srawlins
Copy link
Member

See the tests for what currently fails: Properties on mixins are not generated, and the program will infinitely loop without the new break.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Mar 10, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.781% when pulling 4b29749 on srawlins:mustachio-u into c4daaf9 on dart-lang:master.

@srawlins srawlins requested a review from jcollins-g March 10, 2021 18:26
@srawlins srawlins merged commit 95ec941 into dart-lang:master Mar 10, 2021
@srawlins srawlins deleted the mustachio-u branch March 10, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srawlins @coveralls @jcollins-g