Skip to content

Do not perform hint or lint analysis while resolving files #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

srawlins
Copy link
Member

Dartdoc previously skipped hints and lints, but this behavior was lost in the transition to ContextCollections.

This saves 10s of 210s in resolving Flutter's files while compiling Flutter's docs.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Mar 10, 2021
@srawlins
Copy link
Member Author

Oops. CI failing left and right. Maybe in an unreleased version of analyzer...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 91.264% when pulling eb31d16 on srawlins:hint into 0a83b0f on dart-lang:master.

@srawlins srawlins requested a review from jcollins-g March 18, 2021 20:36
@srawlins srawlins merged commit 05192a2 into dart-lang:master Mar 19, 2021
@srawlins srawlins deleted the hint branch March 19, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants